Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validatror isSlug() not working properly #1287

Closed
rubanshah opened this issue Apr 25, 2020 · 4 comments
Closed

validatror isSlug() not working properly #1287

rubanshah opened this issue Apr 25, 2020 · 4 comments
Labels
🐛 bug

Comments

@rubanshah
Copy link

validator.isSlug('adfAA ()'); returns true
it should not allow white space
@profnandaa
Copy link
Member

Bug confirmed; PR welcome.

@VusalIs
Copy link

VusalIs commented May 3, 2020

Hi. I found this solution (https://stackoverflow.com/questions/22454258/js-regex-string-validation-for-slug). If this regex suitable for the purpose of function, I would like to make a pull request.

@profnandaa
Copy link
Member

@VusalIs -- I'd prefer fixing the specific error other than a new regex altogether.

@VusalIs VusalIs mentioned this issue May 6, 2020
Closed
@asp2809 asp2809 mentioned this issue May 31, 2020
Merged
@parasg1999
Copy link
Contributor

Fixed in #1338. Please close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@profnandaa @rubanshah @parasg1999 @VusalIs