Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isBase64("") returns false #1418

Closed
AberDerBart opened this issue Aug 19, 2020 · 4 comments
Closed

isBase64("") returns false #1418

AberDerBart opened this issue Aug 19, 2020 · 4 comments
Labels
☑ assigned 🐛 bug

Comments

@AberDerBart
Copy link
Contributor

The string "" is valid base64 (see first example https://tools.ietf.org/html/rfc4648#section-10) but isBase64("") returns false. This is also errorneous in the tests (see https://github.com/validatorjs/validator.js/blob/master/test/validators.js line 4755).

Originally posted by @AberDerBart in #1239 (comment)
@AberDerBart AberDerBart mentioned this issue Aug 19, 2020
Closed
@heanzyzabala
Copy link
Contributor

Hi, I'll be taking this one. Thanks!

@profnandaa
Copy link
Member

Sure, please do, thanks! and check out the conversation in #1239 too.

@AberDerBart
Copy link
Contributor Author

I have already done it, see #1419

@AberDerBart
Copy link
Contributor Author

As #1419 has been merged, I'm closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☑ assigned 🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@profnandaa @AberDerBart @heanzyzabala