Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you aware of github.com/regexps #461

Closed
simison opened this issue Dec 3, 2015 · 4 comments
Closed

Are you aware of github.com/regexps #461

simison opened this issue Dec 3, 2015 · 4 comments

Comments

@simison
Copy link
Contributor

simison commented Dec 3, 2015

https://github.com/regexps

Using some of these could be a good idea.

@chriso
Copy link
Collaborator

chriso commented Dec 3, 2015

I have seen those before, yes, and my thoughts are that a regex per module is overkill 😉 If a request comes through for one of the validation regexes in that collection that isn't present here then I'll take a look at integrating it, provided the license is reasonable.

For more complicated validators (URL, Email, etc), this library has moved away from single regular expressions to avoid ReDoS vulnerabilities. #152 has some more info.

@chriso chriso closed this as completed Dec 3, 2015
@simison
Copy link
Contributor Author

simison commented Dec 3, 2015

👍 Thanks for elaborating!

@simison
Copy link
Contributor Author

simison commented Dec 3, 2015

BTW excellent job with these:

image

@chriso
Copy link
Collaborator

chriso commented Dec 3, 2015

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants