Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS Filter Failure in isURL #605

Closed
p-hebert opened this issue Nov 25, 2016 · 1 comment
Closed

XSS Filter Failure in isURL #605

p-hebert opened this issue Nov 25, 2016 · 1 comment

Comments

@p-hebert
Copy link

p-hebert commented Nov 25, 2016

The isURL function doesn't filter XSS strings, such as the following:
<script>console.log('injection')</script>

Found out while doing negative testing against the validation in my app.

Example simplified code:

const validator = require('validator');
console.log(validator.isURL('<script>console.log('injection')</script>'));
@p-hebert
Copy link
Author

False positive, the XSS string doesn't go through.
Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant