Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*bytebufferpool.ByteBuffer does not implement io.Reader (missing Read method) #17

Open
delfer opened this issue Jan 28, 2019 · 3 comments
Open

*bytebufferpool.ByteBuffer does not implement io.Reader (missing Read method) #17

delfer opened this issue Jan 28, 2019 · 3 comments

Comments

@delfer
Copy link

delfer commented Jan 28, 2019

It would be more useful to implement Read method like 'bytes.Buffer'
@jjhesk
Copy link

jjhesk commented Feb 23, 2019

i think there is a serious race detection by having this library when using message bytes serialization

@suntong
Copy link

suntong commented Aug 9, 2020 •
edited
Loading

I don't quite understand what @jjhesk actually is trying to say, but I was coming here to ask for the same thing as asked by @delfer.

@nanmu42
Copy link

nanmu42 commented May 7, 2021

Hi, I wonder, is there a specific reason to not implement io.Reader on *bytebufferpool.ByteBuffer? Or is a PR welcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@suntong @jjhesk @delfer @nanmu42