Delete of soft deleted rows fails

[Jerry-Carter]

If you have soft delete enabled, deleting a row will set the column associated with the 'deletedAtKey'. Following this with a forced delete will not result in the row being deleted. The following SQL is generated on PostgreSQL:

DELETE FROM "MyTable" WHERE ("MyTable"."deletedAt" IS NULL OR "MyTable"."deletedAt" > ($1)) AND "MyTable"."id" = ($2) [0x00022aab9bdf99ee (TIMESTAMP), 24 (BIGINT)]

where the timestamp ($1) is after the deletedAtKey column value. The fix may be as simple as changing '>' to '<'. There is currently not a unit test for this case.

[grundoon]

Seems to me that there should be no deletedAt check at all if delete(force: true, on: ...)

[Jerry-Carter]

I'm extending BenchmarkSoftDeletable.swift to cover this case. Will commit once I'm able to run it.

[MrMage]

I am using the following, which should work:

User.query(on: connection, withSoftDeleted: true)
					.filter(\User.id == userID)
					.delete(force: true)

[Jerry-Carter]

Pull request: #628

[tanner0101]

Fixed in #628