Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk space limiting logic does not trigger, Downloaded folder grows too huge #363

Closed
andrewm659 opened this issue Aug 18, 2020 · 5 comments

Comments

@andrewm659
Copy link

In previous versions there were disk space limits. Looks like that has been removed in 0.8.4

@tyxxzjpdez
Copy link

My version is v0.8.3 from ubuntu PPA. And I have the same problem. It means that I have to delete some wallpaper by hand in order to save my disk space. It is really troublesome.

@nogre
Copy link

nogre commented Oct 19, 2020

I also would like this feature reactivated. Even if there was only a notification that a space limit was reached, as opposed to automatically deleting images, it would be preferable to having to manually checking disk space usage.

@peterlevi
Copy link
Member

Only the UI for this feature has been removed, because the defaults are good-enough for most users, while putting a wrong number there could have bad effects for users who didn't understand the setting. By default there is a limit of 1gb. Everything around the feature is still editable via the config: https://github.com/varietywalls/variety/blob/master/data/config/variety.conf#L20.

@nogre
Copy link

nogre commented Oct 19, 2020

Well, it then appears that the quota isn't working for me. This install has been running a very long time and maybe I screwed something up a while ago. Hopefully a reinstall will fix it. Thanks for the great program.

@peterlevi peterlevi changed the title Disk space limit Disk space limit logic does not work Oct 19, 2020
@peterlevi
Copy link
Member

peterlevi commented Oct 19, 2020

@nogre thanks for raising the issue. I checked the logic and there is a bug that I have introduced last July with d7e686d, related to the recent significant changes to downloading. Committing a fix to the logic. Otherwise my position regarding the UI is still that it's not needed (as long as the defaults actually work and are not broken as was the case...).

@peterlevi peterlevi changed the title Disk space limit logic does not work Disk space limiting logic does not trigger, Downloaded folder grows too huge Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants