Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

64 bits VXIDs in Varnish 7.3.0 #20

Open
delthas opened this issue Jul 12, 2023 · 0 comments · May be fixed by #21
Open

64 bits VXIDs in Varnish 7.3.0 #20

delthas opened this issue Jul 12, 2023 · 0 comments · May be fixed by #21

Comments

@delthas
Copy link

delthas commented Jul 12, 2023

Hi,

I just read Varnish 7.3.0 upgrade notes and they mention that:

The binary format of Varnish logs changed to increase the space for VXIDs from 32 bits to 64. This is not a change that older versions of the Varnish logging utilities can understand, and the new utilities can also not process old logs.

However I see in the library that all mentions of VXIDs use uint32_t. Is this intended or are there changes needed in the library to support Varnish 7.3.0?

Thanks ❤️
delthas added a commit to delthas/vago that referenced this issue Jul 20, 2023
@delthas
Support VSL version 1 and 64-bit VXIDs
e96c8b3 
The VSL format was changed, with 3 header lines instead of 2.
Namely, VXIDs are now 64-bit integers.

This breaks the library interface (because we change the callback
type).

Using the version field, we can still support reading the
previous version of the VSL records.

See: https://github.com/varnishcache/varnish-cache/blob/varnish-7.2.1/include/vapi/vsl_int.h
See: https://github.com/varnishcache/varnish-cache/blob/varnish-7.3.0/include/vapi/vsl_int.h
Fixes: varnishcache-friends#20
@delthas delthas linked a pull request Jul 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support VSL version 1 and 64-bit VXIDs delthas/vago
1 participant
@delthas