Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adjusting the volume of a MP3 file in glue using the volume slider - multiple incrementing tasks appears leading to crashes #1668

Open
mza299 opened this issue Dec 26, 2024 · 2 comments

Comments

@mza299
Copy link

mza299 commented Dec 26, 2024

To recreate this:

1.) I dragged and dropped an MP3 file onto GameScreen/Files in glue
2.) under the song tab, I ticked “set volume” and adjusted the slider.
3.) numerous tasks appeared in glue under “task remaining”. These tasks have the same text. “Saving Glue (ASAP)”

This eventually led to crashes to the extent that , once rebooted, glue could not load the vs solution of my project.

@vchelaru
Copy link
Owner

vchelaru commented Dec 26, 2024

There are a few problems here:

  1. When the volume slider was changed, it would re-save the entire Glue project including all screens and entities. This is slow, and can cause a backup of tasks.
  2. If a Glue project references a screen or entity json file which is empty, then that gets loaded as null, and that null element is then added to the Glue project, causing the projct to fial to load.
  3. A corruption can happen when saving, wiping the contents of a json file.
  4. If a file is missing or corrupt or invalid, glue should show an error so the user can react and try to fix this

I've fixed #1 and #2 which will make errors less likely, and less catastrophic. I still need to work on #3

@vchelaru
Copy link
Owner

first two issues are fixed here:

8c8df2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants