Use an Informer to list LimitRanges 🥼

Using a LimitRange lister here instead, so this doesn't end up hitting the real API server on each call. Taking into account a review : tektoncd#4176 (comment). Signed-off-by: Vincent Demeester <[email protected]>
vdemeester · Sep 16, 2021 · ae38366 · ae38366
1 parent ff860df
commit ae38366
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/pkg/internal/limitrange/limitrange.go b/pkg/internal/limitrange/limitrange.go
@@ -20,23 +20,25 @@ import (
 
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/client-go/kubernetes"
+	limitrangeinformer "knative.dev/pkg/client/injection/kube/informers/core/v1/limitrange"
 )
 
 func getVirtualLimitRange(ctx context.Context, namespace string, c kubernetes.Interface) (*corev1.LimitRange, error) {
-	limitRanges, err := c.CoreV1().LimitRanges(namespace).List(ctx, metav1.ListOptions{})
+	limitrangeInformer := limitrangeinformer.Get(ctx)
+	limitRanges, err := limitrangeInformer.Lister().LimitRanges(namespace).List(labels.Everything())
 	if err != nil {
 		return nil, err
 	}
-	var limitRange corev1.LimitRange
+	var limitRange *corev1.LimitRange
 	switch {
-	case len(limitRanges.Items) == 0:
+	case len(limitRanges) == 0:
 		// No LimitRange defined
 		break
-	case len(limitRanges.Items) == 1:
+	case len(limitRanges) == 1:
 		// One LimitRange defined
-		limitRange = limitRanges.Items[0]
+		limitRange = limitRanges[0]
 	default:
 		// Several LimitRange defined
 		// Create a virtual LimitRange with
@@ -45,8 +47,9 @@ func getVirtualLimitRange(ctx context.Context, namespace string, c kubernetes.In
 		// - Default that "fits" into min/max taken above
 		// - Default request that "fits" into min/max taken above
 		// - Smallest ratio (aka the most restrictive one)
+		limitRange = &corev1.LimitRange{}
 		m := map[corev1.LimitType]corev1.LimitRangeItem{}
-		for _, lr := range limitRanges.Items {
+		for _, lr := range limitRanges {
 			for _, item := range lr.Spec.Limits {
 				_, exists := m[item.Type]
 				if !exists {
@@ -74,7 +77,7 @@ func getVirtualLimitRange(ctx context.Context, namespace string, c kubernetes.In
 			}
 		}
 		// Handle Default and DefaultRequest
-		for _, lr := range limitRanges.Items {
+		for _, lr := range limitRanges {
 			for _, item := range lr.Spec.Limits {
 				// Default
 				m[item.Type].Default[corev1.ResourceCPU] = minOfBetween(m[item.Type].Default[corev1.ResourceCPU], item.Default[corev1.ResourceCPU], m[item.Type].Min[corev1.ResourceCPU], m[item.Type].Max[corev1.ResourceCPU])
@@ -90,7 +93,7 @@ func getVirtualLimitRange(ctx context.Context, namespace string, c kubernetes.In
 			limitRange.Spec.Limits = append(limitRange.Spec.Limits, v)
 		}
 	}
-	return &limitRange, nil
+	return limitRange, nil
 }
 
 func maxOf(a, b resource.Quantity) resource.Quantity {