Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MtApi.mq4 #238

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update MtApi.mq4 #238

wants to merge 1 commit into from

Conversation

eabase
Copy link
Contributor

@eabase eabase commented Nov 29, 2020

Fixed formatting, encoding and trading bug

  • Fixed preventive use of trading password (bug Not able to use MtApi EA with investor password #223)
  • Converted file from weird UTF-16LE to UTF-8
  • Removed blank trailing spaces
  • Removed tabs and converted mixed 3-tab indentation to 4-spaces
  • Simplified and reduced the Case statements
  • Changed old-school "fun() \n {" to "fun() {" formatting, saving 1500 lines.
  • Bumped version to 1.15

Fixed formatting, encoding and trading bug

* Converted file from weird UTF-16LE to UTF-8
* Removed blank trailing spaces
* Removed tabs and converted mixed 3-tab indentation to 4-spaces
* Simplified and reduced the Case statements
* Changed old-school "fun() \n {" to "fun() {" formatting, saving 1500 lines.
@vdemydiuk
Copy link
Owner

@eabase please make PR into dev branch. I will merge it into master from dev.

@eabase eabase changed the base branch from master to dev November 30, 2020 21:59
@eabase
Copy link
Contributor Author

eabase commented Dec 1, 2020

@vdemydiuk
If you want to compare this to your version, you need to change the character encoding of your version.
It seem that GitHub thinks its binary...
use:

iconv.exe -f UTF-16 -t "ASCII" MtApi.mq4 >MtApi.cpp

Or to UTF-8. Then:
mv MtApi.cpp MtApi.mq4.

vdemydiuk added a commit that referenced this pull request Dec 5, 2020
@BryanStackpole
Copy link

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

@eabase
Copy link
Contributor Author

eabase commented Jan 31, 2021

@BryanStackpole

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

Nobody can help you if you don't file a proper bug report of what you did, and what the output is.
...and this are comments for a pull request, not the issue section.

@BryanStackpole
Copy link

@BryanStackpole

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

Nobody can help you if you don't file a proper bug report of what you did, and what the output is.
...and this are comments for a pull request, not the issue section.

Yeah sry about that. I think the answer is in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants