Apply design changes to WYSIWYG editor

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other : Apply the right designs to the rich text editor.

Content

Adjusted sizes, round corners, colours, backgrounds, added menu state feedback, fixed proguard issues.

Motivation and context

#7288 only set up the initial integration, but we still needed to implement some of the design decisions.

Screenshots / GIFs

Before	After

Tests

• Enable rich text editor in lab flags.
• Open a DM/room and use formatting.

Tested devices

• Physical
• Emulator
• OS version(s): 13

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[bmarty]

Some small remarks. Also the CI is not happy because of the usage of colorAccent. Can you check please? (this is maybe a false positive)

[bmarty]

I would rename to Widget.Vector.EditText.RichTextComposer, to avoid the confusion with the parenting (parent style is Widget.AppCompat.EditText, not Widget.Vector.EditText.Composer).

Or eventually just write:

    <style name="Widget.Vector.EditText.Composer.RichText">
        <item name="android:minHeight">20dp</item>
        <item name="android:padding">0dp</item>
    </style>

[bmarty]

Better to use tools:contentDescription, since this will be changed at runtime.

[jmartinesp]

It seems like this is not enough. See #7354 (comment).

[bmarty]

Suggested change

	<style name="Widget.Vector.EditText.Composer.RichTextComposer" parent="Widget.AppCompat.EditText">
	<style name="Widget.Vector.EditText.RichTextComposer" parent="Widget.AppCompat.EditText">

?

[jmartinesp]

Sorry, I changed it to the correct value, and also corrected the references to this style in the views.

[jmartinesp]

There are a couple of other design changes to review.

[ElementBot]

	Warnings
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageViews.kt#L63 - Custom view AudioWaveformView has setOnTouchListener called on it but does not override performClick
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageViews.kt#L63 - Custom view AudioWaveformView has setOnTouchListener called on it but does not override performClick
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageViews.kt#L63 - onTouch lambda should call View#performClick when a click is detected
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageViews.kt#L63 - onTouch lambda should call View#performClick when a click is detected

Generated by 🚫 dangerJS against a38255b

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[bmarty]

Thanks for the update. Latest commits are fine too. 👍