Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliable Storage: Improve detection of fallback stores #9309

Closed
jryans opened this issue Mar 28, 2019 · 1 comment
Closed

Reliable Storage: Improve detection of fallback stores #9309

jryans opened this issue Mar 28, 2019 · 1 comment
Assignees
@jryans
Labels
A-Storage Storage layer of the app, including IndexedDB, local storage, etc. P1 T-Enhancement X-Release-Blocker

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 28, 2019

We should improve detection of fallback stores, like local storage for crypto, memory storage, etc. so that we report accurate results.
@jryans jryans self-assigned this Mar 28, 2019
@jryans jryans mentioned this issue Mar 28, 2019
Closed
5 tasks
jryans added a commit to jryans/matrix-js-sdk that referenced this issue Mar 28, 2019
@jryans
Add existence check to local storage based crypto store
20f4469 
This supports additional diagnostics of stores in
element-hq/element-web#9309.
@jryans jryans mentioned this issue Mar 28, 2019
Merged
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 28, 2019
@jryans
Check the local storage fallback for crypto store
1928c43 
This adds additional consistency checks to examine the local storage fallback
for the crypto store as well as the primary IndexedDB variant.

Part of element-hq/element-web#9309
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 28, 2019
@jryans
Clarify when memory stores are being used
f396cf8 
This adds logging for the cases where memory only stores are being used. It also
reorganises the sync store path to match the crypto store.

Part of element-hq/element-web#9309
@jryans jryans mentioned this issue Mar 28, 2019
Merged
@jryans
Copy link
Collaborator Author

jryans commented Mar 28, 2019

These improvements would be good to have in the release for better reporting, so marking release-blocker.

turt2live pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 29, 2019
@jryans @turt2live
Check the local storage fallback for crypto store
4c65587 
This adds additional consistency checks to examine the local storage fallback
for the crypto store as well as the primary IndexedDB variant.

Part of element-hq/element-web#9309
turt2live pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 29, 2019
@jryans @turt2live
Clarify when memory stores are being used
83931a4 
This adds logging for the cases where memory only stores are being used. It also
reorganises the sync store path to match the crypto store.

Part of element-hq/element-web#9309
turt2live pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 29, 2019
@jryans @turt2live
Add existence check to local storage based crypto store
d753db5 
This supports additional diagnostics of stores in
element-hq/element-web#9309.
@jryans jryans added the A-Storage Storage layer of the app, including IndexedDB, local storage, etc. label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Storage Storage layer of the app, including IndexedDB, local storage, etc. P1 T-Enhancement X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jryans