-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry sink): new sink #21866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: sinks
Anything related to the Vector's sinks
label
Nov 21, 2024
github-actions
bot
added
the
domain: external docs
Anything related to Vector's external, public documentation
label
Nov 25, 2024
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.49s Total Time |
estherk15
approved these changes
Nov 25, 2024
Co-authored-by: Esther Kim <[email protected]>
Co-authored-by: Esther Kim <[email protected]>
Co-authored-by: Esther Kim <[email protected]>
bfung
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for v1. Can merge when PR checks all green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain: external docs
Anything related to Vector's external, public documentation
domain: sinks
Anything related to the Vector's sinks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces basic support for pushing data to OTEL.
There are numerous potential improvements:
Which will be tackled in future releases.
Change Type
Is this a breaking change?
How did you test this PR?
Vector Config
Run Vector:
OTEL config:
Run OTEL collector:
Sample output:
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References
opentelemetry
source and sink #1444