Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output data source name more relevant to the spec name. #3789

Open
kanitw opened this issue May 22, 2018 · 2 comments
Open

Make output data source name more relevant to the spec name. #3789

kanitw opened this issue May 22, 2018 · 2 comments
Labels
Area - Data & Transform P2 Important Issues that should be fixed soon
Milestone

Comments

@kanitw
Copy link
Member

kanitw commented May 22, 2018

This will make debugging much easier. Right now we have no idea if data_0, data_1, etc are for which data sources.

Given we're merging data source sometimes, we need to come up with a good merging rule too.
(A dumb one could be concatenating previous name.)

@kanitw kanitw added this to the 2.x Data & Transforms Patches milestone May 22, 2018
@kanitw
Copy link
Member Author

kanitw commented May 22, 2018

  • We should try to see if we can make data source name depends on spec name.

  • Also, we can make default unit spec names includes its mark type too/

Basically, modify the first line of UnitModel constructor:

-super(spec, parent, parentGivenName, config, repeater, undefined);
+super(spec, parent, parentGivenName + '_' + (isMarkDef(spec.mark) ? spec.mark.type : spec.mark), config, repeater, undefined);

@domoritz
Copy link
Member

domoritz commented May 28, 2018

  • 2) Name sources by the dataset
  • 1) Use explicit spec name
  • (Let's not do for now) 3) Name data sources by the implicit unit spec name if it's a leaf (a node can be a leaf iff it is a unit spec) -- this name should be based on the mark like kanitw suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Data & Transform P2 Important Issues that should be fixed soon
Projects
None yet
Development

No branches or pull requests

3 participants