Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config examples to migration docs #704

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

LandonTClipp
Copy link
Collaborator

This fixes #703

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.38746% 🎉

Comparison is base (8965d12) 74.50375% compared to head (375bfeb) 74.89121%.
Report is 4 commits behind head on master.

❗ Current head 375bfeb differs from pull request most recent head 6f51f40. Consider uploading reports for the commit 6f51f40 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #704         +/-   ##
===================================================
+ Coverage   74.50375%   74.89121%   +0.38746%     
===================================================
  Files              9           9                 
  Lines           2267        2298         +31     
===================================================
+ Hits            1689        1721         +32     
+ Misses           441         440          -1     
  Partials         137         137                 

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes vektra#703

Fixing incorrect statement in docs.

It's `inpackage` that controlled whether or not something was placed
next to an interface, not `keeptree`.
@LandonTClipp LandonTClipp merged commit 72c48ed into vektra:master Sep 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 migration guide is confusing
1 participant