[Feature] Add new string template functions #705
Conversation
list of funcs: - lower - upper - title - camelcase - snakecase - kebabcase - firstLower - firstUpper change the dependency for strings ops "iancoleman/strcase" -> "huandu/xstrings"
SirSova
changed the title
|
@LandonTClipp please review the PR, cuz I can't edit Reviewers section. |
pkg/outputter.go
Outdated
| InterfaceNameCamel: xstrings.ToCamelCase(iface.Name), | ||
| InterfaceNameLowerCamel: xstrings.FirstRuneToLower(xstrings.ToCamelCase(iface.Name)), | ||
| InterfaceNameSnake: xstrings.ToSnakeCase(iface.Name), |
There was a problem hiding this comment.
Does this have any behavior differences or are they strictly equivalent? I'm inclined to keep the old package populating these variables and just remove them in v3.
There was a problem hiding this comment.
as far as I see, they behave absolutely the same.
But since they are deprecated I guess it's okay to keep code unchanged.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
===================================================
- Coverage 74.89121% 74.88090% -0.01032%
===================================================
Files 9 9
Lines 2298 2309 +11
===================================================
+ Hits 1721 1729 +8
- Misses 440 442 +2
- Partials 137 138 +1
☔ View full report in Codecov by Sentry. |
add deprecation comment
SirSova
force-pushed
the
feature/702
branch
from
b77a56a to
8b0b6a3
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
List of new funcs:
change the dependency for strings ops "iancoleman/strcase" -> "huandu/xstrings"
deprecate the custom "InterfaceName" template variables
Description
Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Unit tests. Build and run mockery with new functions applied to a template locally.
Checklist