Make the parser accept index list expressions #857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interfaces defined as instantiation of generic interfaces with more than one type parameter (example) are described as
*ast.IndexListExpr
by Go's AST library.These interfaces were not accepted by the parser. This PR solves the issue by adding index list expressions as an accepted expression type.
*ast.IndexListExpr
are not accepted #856Type of change
Version of Go used when building/testing:
How Has This Been Tested?
Added a new fixture illustrating the case and ran custom builds against it before and after the change, confirming the mock was produced as expected after the fix.
I also added a generator test for this specific case.
Checklist