Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically publish to npm #88

Merged
merged 3 commits into from
Sep 5, 2023
Merged

feat: automatically publish to npm #88

merged 3 commits into from
Sep 5, 2023

Conversation

cb1kenobi
Copy link
Contributor

Adds a publish step after tests run.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a few files.

Needs a release config and also would be good to validate the PR title with the additional workflow. Also the version could be 0.0.0 so no one gets confused about manually versioning.

vercel/satori#350

@cb1kenobi
Copy link
Contributor Author

Added the config and set the version to 0.0.0-development.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Remember we need to add the gh secret to this repo

@styfle styfle mentioned this pull request Sep 5, 2023
@cb1kenobi
Copy link
Contributor Author

Secret has been added to repo.

@cb1kenobi cb1kenobi merged commit 2c161a5 into main Sep 5, 2023
3 checks passed
@cb1kenobi cb1kenobi deleted the auto-publish-npm branch September 5, 2023 21:35
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants