Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks at the end of a sentence erroneously include the period #4444

Open
jaraco opened this issue Apr 1, 2020 · 3 comments
Open

Hyperlinks at the end of a sentence erroneously include the period #4444

jaraco opened this issue Apr 1, 2020 · 3 comments

Comments

@jaraco
Copy link

jaraco commented Apr 1, 2020

I'm using the Azure CLI, and one of the help outputs had this text:

jaraco.functools master $ az devops service-endpoint github create --help

Command
    az devops service-endpoint github create : Create a GitHub service endpoint.
        For automation, set GitHub PAT token in AZURE_DEVOPS_EXT_GITHUB_PAT environment variable.
        You can learn more about this at https://aka.ms/azure-devops-cli-service-endpoint.

If I try to click on that URL, it is highlighted, but it doesn't work because the . is included in the URL. Many other systems like Slack are able to detect hyperlinks like these without including extraneous trailing characters. It would be nice if Hyper could do the same.

@LabhanshAgrawal
Copy link
Collaborator

The weblinks functionality comes from xterm itself, I think you should report it there instead.
Though I guess it might be difficult as . is a valid character in urls.

@jaraco
Copy link
Author

jaraco commented Dec 6, 2023

I've observed that it's not just the period, but any punctuation, including >, ), and probably others.

image

@jaraco
Copy link
Author

jaraco commented Dec 6, 2023

The upstream bug has been fixed (ref). What will it take to get this fix integrated into Hyper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants