fix: normalize asset prefix for socket if start with http

vercel · Aug 5, 2024 · 1182627 · 1182627
1 parent c74f3f5
commit 1182627
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/next/src/client/components/react-dev-overlay/internal/helpers/get-socket-url.ts b/packages/next/src/client/components/react-dev-overlay/internal/helpers/get-socket-url.ts
@@ -18,7 +18,7 @@ export function getSocketUrl(assetPrefix: string | undefined): string {
 
   // if original assetPrefix is a full URL with protocol
   // we just update to use the correct `ws` protocol
-  if (assetPrefix?.replace(/^\/+/, '').includes('://')) {
+  if (assetPrefix?.startsWith('http')) {
     return `${protocol}://${prefix}`
   }
 

diff --git a/packages/next/src/shared/lib/normalized-asset-prefix.ts b/packages/next/src/shared/lib/normalized-asset-prefix.ts
@@ -1,8 +1,9 @@
 export function normalizedAssetPrefix(assetPrefix: string | undefined): string {
   const escapedAssetPrefix = assetPrefix?.replace(/^\/+/, '') || false
 
-  // assetPrefix as a url
-  if (escapedAssetPrefix && escapedAssetPrefix.startsWith('://')) {
+  if (escapedAssetPrefix && escapedAssetPrefix.startsWith('http')) {
+    // remove protocol for socket url
+    // https://example.com/path/to/asset -> example.com/path/to/asset
     return escapedAssetPrefix.split('://', 2)[1]
   }