-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eventually support/use multiple React roots? #50
Comments
Using more than one React root is a rather unusual solution to this problem. Did you test if Next.js routing actually prevents reconciliation and thus, common elements like a shared |
In the issue #88, I suggest having an editable top-level App container where these common elements could reside. This could be a solution to your problem as well. |
@dlindenkreuz I think that's the simplest solution here and fits this projects' philosophy best. |
@dlindenkreuz Currently, Next eschews React's reconciler during client-side navigation and re-renders the entire dev-prodvided tree. This is because the of how React's reconciler works w.r.t. a component's It would be possible to use the same top-level page component by always exporting it from all your Another reason I'm bringing up multiple React roots is to support HTTP response streaming that doesn't have to wait for the entire tree to render. I think there's a reasonable middle ground where the dev can provide the app shell (as you're suggesting), and Next does some intelligent rendering (possibly using multiple roots) to allow server response streaming and client-side component instance reuse. |
Here's a link to an example I built that shows how you can re-use a single definition of your layout across all your pages without repeating any code. https://github.com/mmmeff/nextjs-page-template-example |
@mmmeff I'm not talking about reuse at the coding level, I'm talking about component instance reuse at the React reconciler level during runtime in the browser. What you have will still be entirely torn down between client-side navigations because https://facebook.github.io/react/docs/reconciliation.html#the-diffing-algorithm |
@ericf Well aware (and listed it as a caveat in my readme). Any ideas on potential workarounds though? |
@mmmeff a simple solution would be something like @dlindenkreuz suggested with Next allowing the dev to customize the app component which remains the same instance across client-side navigations. The conceptual model would be similar to your example where you create an "app shell". |
@ericf Wow, I honestly never thought this was possible. Can you recommend me some articles to read up on that? A customizable top-level App component would probably solve this in the simple way the project is aiming at. Having multiple roots sounds like a low-level conceptual decision (even though I'm not yet enlightened what this is all about 😀) which should either be left up to the user or which has to be done by Next.js in an elegant, unobtrusive way. |
@dlindenkreuz check out: https://react-server.io
Yeah, I'm thinking about it in terms of a Next implementation detail that the dev isn't concerned with. |
+1 for having a way for the user to maintain state across pages (not necessarily with multiple roots though), for shared navigation elements with their CSS transitions, and also for Redux and GraphQL clients such as Apollo. Maintaining the state in |
Guys, with Eventually, we'll add support tuning options. About the multiple react-roots, it's kind a questionable. Not sure we'll do it by default. I am closing this issue because I think we are clear on this topic. But feel free to reopen if you are looking for something different. |
I noticed that one React root is used, while this is certainly the simplest solution, I'm curious if there's a plan to support or use multiple React roots?
In the current architecture with a single root, a client-side navigation blows away everything visible on the page and re-renders everything for the new route, including parts of the component tree that exist on both routes.
With multiple React roots, common site elements like a
<header>
could be in their own React root, and when the same page "region" exists between two routes the component tree won't need to be torn down and re-rendered during that client-side navigation. An architecture with multiple roots/regions would also allow the server to flush out to the response before waiting for the entire page to be rendered.I imagine that when using Next, it'll be natural to break out common page-level UI component trees, like the site's header, and reuse it on all pages, similar to an "include", and at these page "region" boundaries there's an opportunity to use multiple React roots to speed up both server and client rendering.
So I'm mainly curious if this sort of thing might be part of Next in the future, or if the simplicity of one React root and re-rendering the entire page on client-side navigation is an explicit design decision for the framework?
The text was updated successfully, but these errors were encountered: