-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMR breaks in 13.4.3 and 13.4.4 (and in 13.4.8) when used with custom server #50881
Open
1 task done
Labels
bug
Issue was opened via the bug report template.
Comments
firmableharry
changed the title
HMR breaks in 13.4.3 and 13.4.4 when used with custom server
HMR breaks in 13.4.3 and 13.4.4 (and in 13.4.8) when used with custom server
Jul 6, 2023
Can confirm happening on 13.4.10 too, 13.4.7 was last version it's working on. Currently it does update the UI but then does a full page refresh. I don't think I'm using a custom server so it might be unrelated to that? |
it won't happen in production mode |
Who is using HMR in prod and why are they? |
From a very brief test 13.4.11 looks to have fixed the issue for me |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify canary release
Provide environment information
Which area(s) of Next.js are affected? (leave empty if unsure)
No response
Link to the code that reproduces this issue or a replay of the bug
https://github.com/vercel/next.js/tree/canary/examples/reproduction-template
To Reproduce
Install 13.4.3/13.4.4
Use a custom server
Please have a look at WS in the network.
(sorry for not providing the reproduction repo, as its just 4 lines of custom server)
Describe the Bug
Using a custom dev server as I need https,
This setup works fine and HMR works as expected on 13.4.2, but fails on 13.4.3/13.4.4 and the latest 13.4.5-canary.6.HTTPS
Expected Behavior
HMR should work as normal and expected
Which browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
Its a local only issue
The text was updated successfully, but these errors were encountered: