Ensure we don't poll page in development when notFound: true is returned

[balazsorban44]

Fixes: #34342

Visiting the following page will call gSSP indefinitely in a loop and logs errors from on-demand-entries-client:

const Home = () => null
export default Home
        
export function getServerSideProps() {
  console.log("gssp called")
  return { notFound: true }
}

We should not keep fetching the page if it returns 404 as it can introduce unnecessary data requests.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
buildDuration	19.4s	18.6s	-734ms
buildDurationCached	7.5s	7.3s	-227ms
nodeModulesSize	368 MB	368 MB	⚠️ +1.49 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.767	3.922	⚠️ +0.16
/ avg req/sec	663.7	637.39	⚠️ -26.31
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.576	1.628	⚠️ +0.05
/error-in-render avg req/sec	1586.57	1535.79	⚠️ -50.78

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	27.9 kB	27.9 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.5 kB	71.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	5.01 kB	5.01 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
buildDuration	22.6s	22.2s	-360ms
buildDurationCached	7.2s	7.4s	⚠️ +167ms
nodeModulesSize	368 MB	368 MB	⚠️ +1.49 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.76	3.764	0
/ avg req/sec	664.98	664.19	⚠️ -0.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.573	1.713	⚠️ +0.14
/error-in-render avg req/sec	1589.52	1459.43	⚠️ -130.09

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.1 kB	42.1 kB	✓
main-HASH.js gzip	27.9 kB	27.9 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	5.05 kB	5.05 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.28 kB	2.28 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js test/gssp-not-found-loop	Change
index.html gzip	533 B	533 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 689a4de