Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example with-mongodb to add both Pages & App examples #64130

Closed
wants to merge 13 commits into from
Closed

Update example with-mongodb to add both Pages & App examples #64130

wants to merge 13 commits into from

Conversation

codeSTACKr
Copy link
Contributor

Updated all dependencies and added an app route to demonstrate both pages an app directories.

@codeSTACKr codeSTACKr requested review from a team as code owners April 5, 2024 20:59
@codeSTACKr codeSTACKr requested review from jh3y and delbaoliveira and removed request for a team April 5, 2024 20:59
@ijjk ijjk added the examples Issue/PR related to examples label Apr 5, 2024
Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this example Jesse and Justin! 🙏🏼

Could you please resolve the merge conflict?

@codeSTACKr
Copy link
Contributor Author

Thank you for checking this out @delbaoliveira. I've addressed the conflicts and proceeded to merge. Please let me know if there is anything else needed.

@samcx samcx dismissed delbaoliveira’s stale review July 24, 2024 23:13

merge conflicts fixed

@samcx samcx enabled auto-merge (squash) July 24, 2024 23:14
@samcx
Copy link
Member

samcx commented Jul 24, 2024

@codeSTACKr

It looks like the lint is mad about your HEAD being detached → https://github.com/vercel/next.js/actions/runs/10085328885/job/27885936674?pr=64130.

HEAD detached at pull/64130/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   examples/with-mongodb/next-env.d.ts

@codeSTACKr
Copy link
Contributor Author

@samcx All changes are committed, please try again. Thanks!

@samcx samcx added the CI approved Approve running CI for fork label Aug 2, 2024
@samcx
Copy link
Member

samcx commented Aug 2, 2024

Giving the same issue... hmmm

@samcx samcx removed the CI approved Approve running CI for fork label Aug 2, 2024
@samcx
Copy link
Member

samcx commented Aug 2, 2024

@codeSTACKr I'm not sure if our CI is not happy because you're trying to merge your fork's canary to our canary. Can you try using a different branch?

@samcx samcx disabled auto-merge August 2, 2024 19:27
@codeSTACKr
Copy link
Contributor Author

@samcx Ok, I'll give that a try.

@codeSTACKr
Copy link
Contributor Author

@samcx just created a new PR: #68461

@samcx samcx closed this Aug 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants