Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better info section #85

Closed
leo opened this issue Jan 23, 2017 · 16 comments
Closed

Better info section #85

leo opened this issue Jan 23, 2017 · 16 comments
Labels

Comments

@leo
Copy link
Contributor

leo commented Jan 23, 2017

This needs to be better. Looks like it's designed for devs (shouldn't be the case)!

screen shot 2017-01-23 at 17 56 08

@leo leo added the patch label Jan 23, 2017
@albinekb
Copy link

What is your suggestion, how should it look? @leo 🤔

@derhuerst
Copy link

Is the port relevant? For all production-grade deployments, this will probably run behind a proxy like nginx which has different ports anyways. For all dev-deployments, people will know what ports are and how they work.

Regarding the hostname, I'd argue that it is irrelevant as well, since you only get this message if you've already found the server.

@leo
Copy link
Contributor Author

leo commented Jan 24, 2017

We could improve security by hiding the version number, IP and port.

I honestly just want to mention that it's using serve. Or maybe even hide it completely?

@albinekb
Copy link

albinekb commented Jan 24, 2017

improve obscure security 😉 yes, but I think it's good advertising to have it there if nothing else

@leo
Copy link
Contributor Author

leo commented Jan 24, 2017

Running version 2.4.3 of serve

?

@derhuerst
Copy link

I think the node version is relevant enough and we don't want to support security by obscurity, so i prefer "serve x.x.x running on Node y.y.y".

@leo
Copy link
Contributor Author

leo commented Jan 24, 2017

node version is relevant enough

Relevant for what? We're not running any custom code on there.

@derhuerst
Copy link

@leo

Relevant for what? We're not running any custom code on there.

Just like the serve version, to see if both are up to date.

@leo
Copy link
Contributor Author

leo commented Jan 24, 2017

Serve 2.0.0 running on Node 7.0.0

Is perfect! Also "Serve" and "Node" should be linked.

@derhuerst
Copy link

And "serve" should be lower case, just like in the readme.

@leo
Copy link
Contributor Author

leo commented Jan 24, 2017

@derhuerst Technically, yes. But it's the start of the sentence, so it looks pretty bad. In always capitalize in these cases... 🤔

@derhuerst
Copy link

@leo Interesting, I prefer the opposite. Feel like serve being a proprietary name itself is more important than it being at the beginning of the sentence. 😉

@timneutkens
Copy link
Member

timneutkens commented Jan 25, 2017

Running serve 2.0.0 on Node 7.0.0

^ this might fix both your arguments 😜

@pablopunk
Copy link
Contributor

I would just show

Powered by Serve

IMO the user shouldn't care about the port (which is in the URL) or node version. Linking the name Serve to the github page should be enough if they are curious about it.

@derhuerst
Copy link

Another idea:

Showing nothing would bother less in 99% of the page views. For those who are interested, we can respond with a Server header or https://github.com/zeit/serve.

@leo
Copy link
Contributor Author

leo commented Jan 26, 2017

Yea let's hide this shit and hand the web a present! + Header ❤️

@leo leo closed this as completed in 575ff68 Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants