-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better info section #85
Comments
What is your suggestion, how should it look? @leo 🤔 |
Is the port relevant? For all production-grade deployments, this will probably run behind a proxy like nginx which has different ports anyways. For all dev-deployments, people will know what ports are and how they work. Regarding the hostname, I'd argue that it is irrelevant as well, since you only get this message if you've already found the server. |
We could improve security by hiding the version number, IP and port. I honestly just want to mention that it's using serve. Or maybe even hide it completely? |
|
? |
I think the node version is relevant enough and we don't want to support security by obscurity, so i prefer "serve x.x.x running on Node y.y.y". |
Relevant for what? We're not running any custom code on there. |
Just like the |
Is perfect! Also "Serve" and "Node" should be linked. |
And "serve" should be lower case, just like in the readme. |
@derhuerst Technically, yes. But it's the start of the sentence, so it looks pretty bad. In always capitalize in these cases... 🤔 |
@leo Interesting, I prefer the opposite. Feel like serve being a proprietary name itself is more important than it being at the beginning of the sentence. 😉 |
^ this might fix both your arguments 😜 |
I would just show
IMO the user shouldn't care about the port (which is in the URL) or node version. Linking the name |
Another idea: Showing nothing would bother less in 99% of the page views. For those who are interested, we can respond with a |
Yea let's hide this shit and hand the web a present! + Header ❤️ |
This needs to be better. Looks like it's designed for devs (shouldn't be the case)!
The text was updated successfully, but these errors were encountered: