Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for kysely migration #325

Open
volnei opened this issue Aug 12, 2023 · 3 comments · May be fixed by #307
Open

Support for kysely migration #325

volnei opened this issue Aug 12, 2023 · 3 comments · May be fixed by #307
Assignees
@vvo
Labels
storage: postgres

Comments

@volnei
Copy link

volnei commented Aug 12, 2023 •
edited
Loading

I would be great if we can use kysely migrations. That should be achieved by disabling transactions

Currently we have this error

{
  error:  [VercelPostgresError: VercelPostgresError - 'kysely_transactions_not_supported': Transactions are not supported yet.] {
  code: 'kysely_transactions_not_supported',
  name: 'VercelPostgresError'
}

I think this could be useful

https://kysely-org.github.io/kysely-apidoc/interfaces/DialectAdapter.html#supportsTransactionalDdl
@volnei
Copy link
Author

volnei commented Aug 12, 2023

This could solve the issue

#307 (review)

@savoiringfaire savoiringfaire linked a pull request Aug 14, 2023 that will close this issue
Open
@marciomunhoz
Copy link

Please help us! We need to finalize a project with this fix. 😬

@volnei
Copy link
Author

volnei commented Aug 16, 2023 •
edited
Loading

@marciomunhoz

You can use this until vercel fixes this trivial

Object.defineProperty(
  db.getExecutor().adapter,
  'supportsTransactionalDdl',
  () => false,
)

although it is something absurdly horrible, it works.

@vvo vvo self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvo vvo

Labels
storage: postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add postgresql adapter for Kysely savoiringfaire/storage
4 participants
@vvo @volnei @marciomunhoz @dferber90