Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline recommended configs #40

Open
mrmckeb opened this issue Sep 21, 2022 · 3 comments
Open

Inline recommended configs #40

mrmckeb opened this issue Sep 21, 2022 · 3 comments
Labels
Milestone

Comments

@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 21, 2022

As of the latest release, we've unpinned version dependencies.

This gives users more flexibility, and makes it easier to bump dependencies of this package (like @typescript-eslint) to support new TypeScript versions, etc.

This also introduces the risk of a plugin releasing a change to a recommended config in a minor release, which would be breaking as code that previously passed may now fail. Worse, a rule could be broken/removed in a minor release, breaking the config. We feel these risks are very low, which is why we opted to shelve this work for future.

@mrmckeb mrmckeb added the eslint label Sep 21, 2022
@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jul 6, 2023

This would ideally be automated.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Aug 29, 2023

We've started doing this, starting with the playwright-test config.

@mrmckeb mrmckeb added this to the v6 milestone Aug 29, 2023
@mrmckeb
Copy link
Contributor Author

mrmckeb commented Mar 4, 2024

This is probably more urgent now as more typescript-eslint seems to be shipping changes to these configs in minor updates, example:
typescript-eslint/typescript-eslint#8011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant