Track kubernetes record status based on available pods #159

rgmz · 2021-10-24T06:44:59Z

This fixes #148.

@tsegismont The scope of this PR is admittedly larger than I would like; I found myself re-organizing the existing code to get a better understanding of its function.

This is a first attempt at implementing #148, missing tests coverage, and could no doubt be improved. Let me know your thoughts on the general approach.

Using 3 maps to track service selectors, service's active pods, and the sevices per pod feels sub-optimal, but the intention was to avoid calculating everything on the fly:

vertx-service-discovery/vertx-service-discovery-bridge-kubernetes/src/main/java/io/vertx/servicediscovery/kubernetes/KubernetesServiceImporter.java

Lines 71 to 73 in 048b2e3

    
           private final Map<RecordKey, ServiceSelector> selectorsByService = new HashMap<>(); 
        
           private final Map<RecordKey, List<String>> runningPodsByService = new HashMap<>(); 
        
           private final Map<String, List<RecordKey>> servicesByPod = new HashMap<>();

The way that service status is updated also feels like it could be better (more reactive). For busier k8s instances, simply checking the size of the lists after modification may not work (concurrent modification). Ideally, we'd hook into the changes in the lists and update the services based on that.

vertx-service-discovery/vertx-service-discovery-bridge-kubernetes/src/main/java/io/vertx/servicediscovery/kubernetes/KubernetesServiceImporter.java

Lines 535 to 542 in 048b2e3

    
           List<String> runningPods = runningPodsByService.computeIfAbsent(key, k -> new ArrayList<>()); 
        
           runningPods.add(podId); 
        
           servicesByPod.computeIfAbsent(podId, k -> new ArrayList<>()) 
        
             .add(key); 
        
           if (runningPods.size() == 1) { 
        
             return updateRecordStatus(key, Status.UP); 
        
           } else {

vertx-service-discovery/vertx-service-discovery-bridge-kubernetes/src/main/java/io/vertx/servicediscovery/kubernetes/KubernetesServiceImporter.java

Lines 550 to 556 in 048b2e3

    
           List<RecordKey> keys = servicesByPod.remove(podId); 
        
           keys.forEach(key -> { 
        
             List<String> runningPods = runningPodsByService.get(key); 
        
             runningPods.remove(podId); 
        
             if (runningPods.isEmpty()) { 
        
               updates.add(updateRecordStatus(key, Status.OUT_OF_SERVICE)); 
        
             }

To-do:

Handle events for pod watch (BOOKMARK, etc.)
Add/fix tests
Remove unnecessary classes
Fix up Java Doc

Signed-off-by: Richard Gomez <[email protected]>

tsegismont · 2022-09-30T13:25:47Z

Hi @rgmz , sorry this went out my radar... Are you able to resume your work on this?

rgmz added 2 commits October 24, 2021 02:32

refactor(kubernetes): split up code from KubernetesServiceImporter

ea0835c

Signed-off-by: Richard Gomez <[email protected]>

feat(kubernetes): basic pod monitoring implementation

8c42382

Signed-off-by: Richard Gomez <[email protected]>

tsegismont self-assigned this Oct 25, 2021

tsegismont added this to the 4.3.0 milestone Oct 25, 2021

tsegismont removed this from the 4.3.4 milestone Sep 30, 2022

Merge branch 'vert-x3:master' into master

3a3d785

rgmz closed this by deleting the head repository Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track kubernetes record status based on available pods #159

Track kubernetes record status based on available pods #159

rgmz commented Oct 24, 2021 •

edited

Loading

tsegismont commented Sep 30, 2022

	private final Map<RecordKey, ServiceSelector> selectorsByService = new HashMap<>();
	private final Map<RecordKey, List<String>> runningPodsByService = new HashMap<>();
	private final Map<String, List<RecordKey>> servicesByPod = new HashMap<>();

	List<String> runningPods = runningPodsByService.computeIfAbsent(key, k -> new ArrayList<>());
	runningPods.add(podId);
	servicesByPod.computeIfAbsent(podId, k -> new ArrayList<>())
	.add(key);

	if (runningPods.size() == 1) {
	return updateRecordStatus(key, Status.UP);
	} else {

	List<RecordKey> keys = servicesByPod.remove(podId);
	keys.forEach(key -> {
	List<String> runningPods = runningPodsByService.get(key);
	runningPods.remove(podId);
	if (runningPods.isEmpty()) {
	updates.add(updateRecordStatus(key, Status.OUT_OF_SERVICE));
	}

Track kubernetes record status based on available pods #159

Track kubernetes record status based on available pods #159

Conversation

rgmz commented Oct 24, 2021 • edited Loading

tsegismont commented Sep 30, 2022

rgmz commented Oct 24, 2021 •

edited

Loading