Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All splices should represent a singular atomic action #359

Closed
vertexmc opened this issue Jul 21, 2017 · 1 comment · Fixed by #405
Closed

All splices should represent a singular atomic action #359

vertexmc opened this issue Jul 21, 2017 · 1 comment · Fixed by #405
Labels
enhancement needs triage
Milestone
v0.0.22

Comments

@vertexmc
Copy link
Contributor

While reviewing #358, I noticed that node:prop:set events can contain multiple props, but node:prop:del events can only contain a single prop. After a short discussion with @invisig0th, we decided that all splice events should represent singular atomic actions.
@vertexmc vertexmc mentioned this issue Jul 21, 2017
Merged
@vertexmc vertexmc mentioned this issue Aug 18, 2017
Merged
@vertexmc
Copy link
Contributor Author

node:prop:set was the only problem splice

@vEpiphyte vEpiphyte added this to the v0.0.22 milestone Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs triage
Projects
None yet
Milestone
v0.0.22
Development

Successfully merging a pull request may close this issue.

All splices should represent a singular atomic action vertexmc/synapse
2 participants
@vertexmc @vEpiphyte