Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark only specific VertiGIS packages as external #60

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

yonabystedt
Copy link
Contributor

Web can no longer handle requests for @vertigis/arcgis-rest-client

@yonabystedt yonabystedt changed the title Mark only specific VertiGIS packages as external fix: Mark only specific VertiGIS packages as external Aug 27, 2024
Copy link
Collaborator

@scottander scottander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kenlyon
Copy link

kenlyon commented Aug 28, 2024

@yonabystedt We may need a similar change in vertigis/vertigis-workflow-sdk. I'm not entirely sure, though. Someone was trying to create a custom form element that uses @vertigis/react-ui. I think that should be present in VertiGIS Studio Web, so external is probably correct at least for that product.

@yonabystedt
Copy link
Contributor Author

@yonabystedt We may need a similar change in vertigis/vertigis-workflow-sdk. I'm not entirely sure, though. Someone was trying to create a custom form element that uses @vertigis/react-ui. I think that should be present in VertiGIS Studio Web, so external is probably correct at least for that product.

I'll take a look if you like.

@yonabystedt yonabystedt merged commit bf0d60a into master Aug 29, 2024
3 of 4 checks passed
@yonabystedt yonabystedt deleted the fix.webpack.externals branch August 29, 2024 15:48
Copy link

🎉 This PR is included in version 1.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants