fix: add null as extra instead of detail
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`null` should always have been an extra, but was not due to it being marked as an `object` type in JS/TS.
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 7 7
Lines 183 183
Branches 32 32
=======================================
Hits 122 122
- Misses 53 54 +1
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
ghost
pushed a commit
that referenced
this pull request
Apr 22, 2022
### [3.0.4](v3.0.3...v3.0.4) (2022-04-22) ### Bug Fixes * add `null` as extra instead of detail ([#56](#56)) ([2533c01](2533c01))
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullshould always have been an extra, but was not due to it being marked as anobjecttype in JS/TS.