Language Server: Autocomplete for PHPUnit

[thbley]

I'm using psalm-vscode-plugin v1.2.2 with vs-code 1.52.1 / 1.53.0 (and code-server 3.8.1) and tried to get auto-complete working for phpunit 9.5.2 (loaded as composer library). E.g. $this->assertTrue() cannot be autocompleted from PHPUnit\Framework\TestCase -> PHPUnit\Framework\Assert.
When I type $this->assertTrue() manually, detecting invalid parameters works.

I'm not sure it's related to psalm-vscode-plugin or psalm itself, so I also reported this in psalm/psalm-vscode-plugin#34 .

Happens with psalm 4.4.1 and psalm 4.5.1

[psalm-github-bot]

Hey @thomasbley, can you reproduce the issue on https://psalm.dev ?

[thbley]

I think I found my issue:

assertTrue is defined as static: public static function assertTrue().

But I call it in class context $this->assertTrue() as advised by the documentation https://phpunit.readthedocs.io/en/9.5/assertions.html#asserttrue

A change could be this, but I'm not sure it's good for all cases:

+++ b/src/Psalm/Codebase.php
@@ -1497,16 +1497,10 @@ class Codebase
             }
         }
 
-        if ($gap === '->') {
-            $completion_items = $instance_completion_items;
-        } else {
-            $completion_items = array_merge(
-                $instance_completion_items,
-                $static_completion_items
-            );
-        }
-
-        return $completion_items;
+        return array_merge(
+            $instance_completion_items,
+            $static_completion_items
+        );

What do you think about it?

[muglug]

Sorry, again. This is fixed.

[thbley]

No problem, thanks for fixing this issue!