Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve piece turnaround #83

Open
vimpunk opened this issue Dec 21, 2020 · 0 comments
Open

Improve piece turnaround #83

vimpunk opened this issue Dec 21, 2020 · 0 comments

Comments

@vimpunk
Copy link
Owner

vimpunk commented Dec 21, 2020

Currently we wait for disk IO to run to completion. We could hash piece, notify torrent of piece completion, and then attempt a write. This would mean that a failed write would cause an invalid advertisement. Should be a pathological edge case? Once #23 is implemented this shouldn't be a problem in any case.

From libtorrent:

Fundamentally, performance in a bittorrent swarm is achieved by all peers also uploading content. The quicker you can turn around from having downloaded a piece until you can upload it, the better performance and the lower latency before you can take advantage of your upload capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant