Merge pull request #4 from viralpraxis/fix-active-models-attribute-mi…

…sdetection Fix `ActiveModel` attribute misdetection
viralpraxis · Aug 13, 2024 · bba909e · bba909e
2 parents bb099dc + f519d0d
commit bba909e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [1.0.4] - 2024-08-13
+
+- Fix `ActiveModel` attribute misdetection [(#4)](https://github.com/viralpraxis/rspec-description_consistency/pull/4)
+
 ## [1.0.3] - 2024-07-04
 
 - Fix invalid private method verification [(#3)](https://github.com/viralpraxis/rspec-description_consistency/pull/3)

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rspec-description_consistency (1.0.3)
+    rspec-description_consistency (1.0.4)
 
 GEM
   remote: https://rubygems.org/

diff --git a/lib/rspec/description_consistency/consitency_verifier.rb b/lib/rspec/description_consistency/consitency_verifier.rb
@@ -45,10 +45,9 @@ def correct_method_example_group?(description, klass, include_private:)
 
         if description.start_with?('#')
           return true if klass.instance_methods.include?(method_name)
-          return false unless include_private
-          return true if klass.private_instance_methods.include?(method_name)
+          return true if klass.respond_to?(:attribute_names) && klass.attribute_names.include?(method_name.to_s)
 
-          klass.respond_to?(:attribute_names) && klass.attribute_names.include?(method_name.to_s)
+          include_private && klass.private_instance_methods.include?(method_name)
         elsif description.start_with?('.')
           correct_class_method?(method_name, klass, include_private: include_private)
         end

diff --git a/lib/rspec/description_consistency/version.rb b/lib/rspec/description_consistency/version.rb
@@ -2,6 +2,6 @@
 
 module Rspec
   module DescriptionConsistency
-    VERSION = '1.0.3'
+    VERSION = '1.0.4'
   end
 end