Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't sync directory outside home #383

Open
KreAch3R opened this issue Aug 2, 2023 · 5 comments
Open

Can't sync directory outside home #383

KreAch3R opened this issue Aug 2, 2023 · 5 comments

Comments

@KreAch3R
Copy link

KreAch3R commented Aug 2, 2023

Hello,

Is there a vital reason that the google-drive folder needs to be a subdirectory to $HOME? My google-drive location is /media/Data/GoogleDrive (this is a /media mounted second HDD in NTFS) and I am getting these errors in the service runs:

Need a directory name in the current users home directory as second argument. Aborting

If I run grive inside the correct folder manually though, it runs. Can I remove the relevant if statement

if [[ -z "$DIRECTORY" ]] || [[ ! -d "$DIRECTORY" ]] ; then
echo "Need a directory name in the current users home directory as second argument. Aborting."
exit 1
fi
or will it break everything?

@jankatins
Copy link

You probably already can simply start it with a absolute path and it will work. I think... This was there because the default uses HOME for relative path and when I wrote that I was only thinking about relative paths.

@KreAch3R
Copy link
Author

KreAch3R commented Aug 4, 2023

Ok, so I can probably check if I can remove it and if it breaks, given that you didn't think of something completely important that needs the path to be inside $HOME. I was thinking you did it because of permissions.

@KreAch3R
Copy link
Author

KreAch3R commented Aug 4, 2023

I just commented out the lines and syncing with the service files seem to work. I created a PR, I commented them out, I was not sure you would want to have them completely removed in case something breaks and you weren't sure it would work.

@KreAch3R
Copy link
Author

KreAch3R commented Aug 6, 2023

@jankatins
Copy link

See #389 for a PR changing the error message (the code already works like that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants