chore(create-vite): update volar link in helloworld components #12145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
reviewed
Feb 22, 2023
packages/create-vite/template-vue-ts/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
bluwy
reviewed
Feb 25, 2023
| @@ -25,7 +25,7 @@ const count = ref(0) | |||
| </p> | |||
| <p> | |||
| Install | |||
| <a href="https://github.com/johnsoncodehk/volar" target="_blank">Volar</a> | |||
| <a href="https://github.com/vuejs/language-tools" target="_blank">Volar</a> | |||
There was a problem hiding this comment.
I've renamed it back to Volar to keep with the naming in create-vue for now. I think it's more recognizable too.
bluwy
changed the title
bluwy
approved these changes
Feb 25, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates volar links in vue create-vite components
Additional context
Continues on the efforts of these PRs
#7994
#11128
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).