feat(create-vite): add qwik templates #13620

leifermendez · 2023-06-25T14:50:05Z

pr-vite-qwik-convert.mp4

Description

A new template has been added for Qwik Framework

What is the purpose of this pull request?

Bug fix
[x ] New Feature
Documentation update
Other

Before submitting the PR, please make sure you do the following

[x ] Read the Contributing Guidelines.
[x ] Read the Pull Request Guidelines and follow the PR Title Convention.
[x ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

stackblitz · 2023-06-25T14:50:07Z

Run & review this pull request in StackBlitz Codeflow.

manucorporat · 2023-06-25T15:36:30Z

From what i see: the .gitignore needs to be called: _gitignore

bluwy · 2023-06-25T17:27:30Z

I don't think a QwikCity template fits here? Similarly we don't add the SvelteKit template here. At most it's a vanilla Vite + Qwik template similar to the other existing frameworks setup and design. And then we can add a CLI redirect to QwikCity.

leifermendez · 2023-06-26T19:16:24Z

I don't think a QwikCity template fits here? Similarly we don't add the SvelteKit template here. At most it's a vanilla Vite + Qwik template similar to the other existing frameworks setup and design. And then we can add a CLI redirect to QwikCity.

I get it! I changed the starter app and also I added the option to QwikCity like SvelteKit.

@manucorporat WDYT?

ArnaudBarre

There is multiple things that are off compared to others templates (not an issue but need to be justified):

lib mode
ssr entry
tsconfig/.gitignore diverge from other templates

manucorporat · 2023-07-05T12:23:18Z

@patak-dev @ArnaudBarre core qwik team here! worked last week to make sure qwik's CSR is in pair with the rest, 100% standard vite starter, index.html as starting point!

manucorporat · 2023-07-05T12:26:35Z

@leifermendez think we should remove the .eslintrc.cjs

patak-dev · 2023-07-05T12:42:47Z

Thanks @manucorporat, I think we should also remove .eslintignore and .prettierignore. And to align with the rest of the starters, there should be a JS version too.

Also, you could add information on the template README.md or directly in the vite config file about the csr option you used.

We were discussing with @bluwy that with the previous setup that included low-level SSR handling, it was better to merge this into create-vite-extra. But with csr, at least to me, create-vite is a better place.

Just to set the expectations, create-vite templates are barebone and mainly intended to try out Vite (or do bug repros). We always point users to prefer the create starters from the frameworks when possible.

manucorporat · 2023-07-05T13:00:04Z

Done! @patak-dev removed the files as suggested and added the .js version

manucorporat · 2023-07-05T13:10:31Z

Added READMEs!

patak-dev · 2023-07-05T13:25:24Z

Are the .eslintrc.cjs a must? We only added eslint to the React templates because they said React was broken without the eslint hook rules. I think it would be better to remove eslint support if possible.

patak-dev · 2023-07-05T13:27:32Z

There is an extra [package-lock.json](https://github.com/vitejs/vite/pull/13620/files#diff-dded9ed3ccf0f6711806b389d69fe9ccff27addb409d7f9dd28a071a127cc65d) in the new JS template that should be removed too.

manucorporat · 2023-07-05T13:35:05Z

Not really, i misunderstood u, thought u wanted the eslint added! removed

packages/create-vite/template-qwik/src/app.jsx

patak-dev · 2023-07-05T13:54:04Z

packages/create-vite/template-qwik-ts/src/app.tsx

+            width={32}
+            height={32}


The Vite logo has the same size as the framework logo in other templates. See

Same for the JS template

patak-dev · 2023-07-05T14:01:14Z

The templates prompts the user "Edit src/app.tsx and save to test HMR", but when trying it out there is a hard reload instead, and the state is lost. Tested the react one that has the same prompt and it is working. If this is a limitation with Qwik, maybe the prompt could be about editing another component. We have in Vue a HelloWorld component for example (because of unrelated reasons)

Co-authored-by: patak <[email protected]>

manucorporat · 2023-07-05T15:55:03Z

HMR is not implemented in Qwik CSR yet, CSR never been a focus.

Fixed the image size and remove that prompt to the user

patak-dev

Looks good to me now! Thanks for the changes.

bluwy · 2023-07-05T16:47:55Z

The changes look great and follows the convention! I have a small question but not 100% blocking this:

HMR is not implemented in Qwik CSR yet, CSR never been a focus.

I wonder if this CSR setup is something you'd recommend building with Qwik today? If not, it feels a bit weird keeping a template for it. In most docs it looks like QwikCity (or an SSR setup in general) is the preferred starting point.

manucorporat · 2023-07-05T18:24:17Z

There are uses cases! Qwik is equivalent to Vue, Solid, React, (same group). It dont need server, we are coming up with new uses cases for CSR, like mobile apps (Capacitor), Qwik automatic lazy loading is still interesting even without SSR involved!
However never been the active focus.

Regarding HMR i plan to work on this soon, for CSR and improvements for SSR too

bluwy

Awesome. If there are plans for improving CSR, let's get this in 👍

feat: ✨ added qwik-starter 🚀

5defcb1

fix: ⚡ change starter

caaf310

ArnaudBarre reviewed Jun 29, 2023

View reviewed changes

leifermendez added 2 commits July 5, 2023 14:00

vanilla qwik-template

1e53762

qwik 1.2.5

fead1af

leifermendez requested a review from ArnaudBarre July 5, 2023 12:21

leifermendez added 3 commits July 5, 2023 14:30

remove eslint

9eaa62e

remove eslint

4aaab83

Merge branch 'main' into feat/qwik-start

a299bd0

manucorporat added 2 commits July 5, 2023 14:55

😈

c47daf9

🐮

7051b01

manucorporat added 2 commits July 5, 2023 15:04

🏋

137254c

add readme

7e283b4

manucorporat added 2 commits July 5, 2023 15:10

🎷

5f83d46

🌏

f444a3b

📢

cc24a3b

patak-dev reviewed Jul 5, 2023

View reviewed changes

packages/create-vite/template-qwik/src/app.jsx Outdated Show resolved Hide resolved

patak-dev reviewed Jul 5, 2023

View reviewed changes

leifermendez and others added 3 commits July 5, 2023 17:03

🙌

b538401

Co-authored-by: patak <[email protected]>

🌝

71a8a82

⚽️

72fd870

patak-dev approved these changes Jul 5, 2023

View reviewed changes

bluwy approved these changes Jul 6, 2023

View reviewed changes

bluwy changed the title ~~feat: ✨ added qwik-starter 🚀~~ feat(create-vite): add qwik templates Jul 6, 2023

patak-dev merged commit ef4602b into vitejs:main Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(create-vite): add qwik templates #13620

feat(create-vite): add qwik templates #13620

leifermendez commented Jun 25, 2023 •

edited

Loading

stackblitz bot commented Jun 25, 2023

manucorporat commented Jun 25, 2023

bluwy commented Jun 25, 2023

leifermendez commented Jun 26, 2023

ArnaudBarre left a comment

manucorporat commented Jul 5, 2023

manucorporat commented Jul 5, 2023 •

edited

Loading

patak-dev commented Jul 5, 2023

manucorporat commented Jul 5, 2023

manucorporat commented Jul 5, 2023

patak-dev commented Jul 5, 2023

patak-dev commented Jul 5, 2023

manucorporat commented Jul 5, 2023

patak-dev Jul 5, 2023

patak-dev commented Jul 5, 2023

manucorporat commented Jul 5, 2023

patak-dev left a comment

bluwy commented Jul 5, 2023

manucorporat commented Jul 5, 2023 •

edited

Loading

bluwy left a comment

feat(create-vite): add qwik templates #13620

feat(create-vite): add qwik templates #13620

Conversation

leifermendez commented Jun 25, 2023 • edited Loading

Description

What is the purpose of this pull request?

Before submitting the PR, please make sure you do the following

stackblitz bot commented Jun 25, 2023

manucorporat commented Jun 25, 2023

bluwy commented Jun 25, 2023

leifermendez commented Jun 26, 2023

ArnaudBarre left a comment

Choose a reason for hiding this comment

manucorporat commented Jul 5, 2023

manucorporat commented Jul 5, 2023 • edited Loading

patak-dev commented Jul 5, 2023

manucorporat commented Jul 5, 2023

manucorporat commented Jul 5, 2023

patak-dev commented Jul 5, 2023

patak-dev commented Jul 5, 2023

manucorporat commented Jul 5, 2023

patak-dev Jul 5, 2023

Choose a reason for hiding this comment

patak-dev commented Jul 5, 2023

manucorporat commented Jul 5, 2023

patak-dev left a comment

Choose a reason for hiding this comment

bluwy commented Jul 5, 2023

manucorporat commented Jul 5, 2023 • edited Loading

bluwy left a comment

Choose a reason for hiding this comment

leifermendez commented Jun 25, 2023 •

edited

Loading

manucorporat commented Jul 5, 2023 •

edited

Loading

manucorporat commented Jul 5, 2023 •

edited

Loading