resolve.conditions not working reliably on custom environment

[hi-ogawa]

Describe the bug

I'm testing a custom environment like:

  environments: {
    worker: {
      webCompatible: true,
      resolve: {
        conditions: ["worker"],
        noExternal: true,
      },
    },

and a package like:

{
  "name": "test-dep-conditions",
  "private": true,
  "type": "module",
  "exports": {
    ".": {
      "worker": "./index.worker.js",
      "browser": "./index.browser.js",
      "default": "./index.default.js"
    }
  }
}

When importing such package both from default client environment and custom environment, custom environment side picks up ./index.browser.js in some cases.

Reproduction

https://github.com/hi-ogawa/reproductions/tree/main/vite-environment-resolve-condition

Steps to reproduce

• open https://stackblitz.com/github/hi-ogawa/reproductions/tree/main/vite-environment-resolve-condition?file=src%2Fentry.tsx
  • shows client: index.browser.js correctly
• click /worker link
  • shows worker: index.browser.js but it's expected to show worker: index.worker.js
• go back and click /custom1 link
  • shows custom1: index.browser.js but it's expected to show custom1: index.custom1.js
• kill server (Control+C) and restart
• click /worker link again
  • now it shows worker: index.worker.js
• go back and click /custom1 link
  • shows custom1: index.worker.js but it's expected to show custom1: index.custom1.js

In this reproduction, I added three extra custom environments with and without webCompatible: true. It looks like the one with webCompatible has some mixed up resolutions depending on the order how they are resolved. It looks like resolution is cached by webCompatible, so for each true/false case, resolution depends on the order how they are resolved.

I also tested with the latest https://pkg.pr.new/vite@95020ab but the behavior seems to be same.

System Info

(stackblitz)

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vite: 6.0.0-beta.1 => 6.0.0-beta.1

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[hi-ogawa]

It looks like the issue is setResolvedCache/getResolvedCache's cache key relying on webCompatible:

vite/packages/vite/src/node/packages.ts

Lines 28 to 29 in 95020ab

	setResolvedCache: (key: string, entry: string, targetWeb: boolean) => void
	getResolvedCache: (key: string, targetWeb: boolean) => string | undefined

Similar issue about the fact that cache key is too coarse is discussed in #12957 (comment)

[patak-dev]

This was broken before too then, in case ssr.resolve.conditions was different. setResolvedCache and getResolvedCache should be per environment, and not only keyed against webCompatible, no?

[hi-ogawa]

This was broken before too then, in case ssr.resolve.conditions was different.

Probably so but maybe only when ssr.target: 'webworker' which makes both client and ssr targetWeb: true.

setResolvedCache and getResolvedCache should be per environment, and not only keyed against webCompatible, no?

I haven't digested the other issue #12957 (comment) but it looks like per-environment is not enough since there might be a case where single environment should resolve differently based on isRequire etc...

---

EDIT: I checked Vite 5 and indeed the issue is the same but only when ssr.target: 'webworker' https://github.com/hi-ogawa/reproductions/blob/main/vite-environment-resolve-condition/repro-v5.js