Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): distinguish pnpm pkgManager #4220

Merged
merged 9 commits into from
Jul 30, 2021
Merged

Conversation

1wkk
Copy link
Contributor

@1wkk 1wkk commented Jul 12, 2021

Description

Same as #4193 , slove conflict.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@1wkk
Copy link
Contributor Author

1wkk commented Jul 12, 2021

@antfu @Shinigami92 review

antfu
antfu previously approved these changes Jul 12, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 12, 2021
Shinigami92
Shinigami92 previously approved these changes Jul 12, 2021
packages/create-vite/index.js Outdated Show resolved Hide resolved
@1wkk 1wkk dismissed stale reviews from Shinigami92 and antfu via 1a1a95a July 14, 2021 14:20
@1wkk 1wkk requested a review from patak-dev July 14, 2021 14:22
@1wkk
Copy link
Contributor Author

1wkk commented Jul 30, 2021

@patak-js Maybe you forgot it?

@patak-dev
Copy link
Member

Tests are blocked, I dont know why. Would you try to merge main?

packages/create-vite/index.js Show resolved Hide resolved
packages/create-vite/index.js Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Jul 30, 2021
@1wkk
Copy link
Contributor Author

1wkk commented Jul 30, 2021

Tests are blocked, I dont know why. Would you try to merge main?

This may be because I send a request review to you, and util mentioned that 'patak-js requested changes', I have marked that conversation as resolved, sorry for I don't have much experience in this field.

patak-dev
patak-dev previously approved these changes Jul 30, 2021
@patak-dev
Copy link
Member

Tests are blocked, I dont know why. Would you try to merge main?

This may be because I send a request review to you, and util mentioned that 'patak-js requested changes', I have marked that conversation as resolved

I don't think that is the case, it looks like a GitHub bug to me

sorry for I don't have much experience in this field.

Thanks for this PR, this is a great addition and I hope we'll see you around with other improvements later

@patak-dev patak-dev dismissed stale reviews from Shinigami92 and themself via 78deec2 July 30, 2021 12:41
@1wkk 1wkk closed this Jul 30, 2021
@1wkk 1wkk reopened this Jul 30, 2021
@patak-dev patak-dev merged commit c0a3dbf into vitejs:main Jul 30, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants