Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't modify config #9262

Merged
merged 5 commits into from
Jul 21, 2022
Merged

fix: don't modify config #9262

merged 5 commits into from
Jul 21, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jul 21, 2022 •
edited by sapphi-red
Loading

Description

worker resolved config should use origin user config

refs #9212
refs #9261

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red mentioned this pull request Jul 21, 2022
Closed
9 tasks
@sapphi-red
Copy link
Member

sapphi-red commented Jul 21, 2022 •
edited
Loading

Same as #9261, this PR fixes #9252 too.
https://github.com/vitejs/vite-ecosystem-ci/runs/7441543695?check_suite_focus=true

@sapphi-red sapphi-red added the bug label Jul 21, 2022
@sapphi-red sapphi-red linked an issue Jul 21, 2022 that may be closed by this pull request
[astro ci] Cannot read property 'isSelfAccepting' of undefined #9252
Closed
7 tasks
@poyoho poyoho force-pushed the config/worker-config-override branch from 1461009 to b673cb9 Compare July 21, 2022 03:18
@poyoho
Copy link
Member Author

poyoho commented Jul 21, 2022

move the validate after handle config.
move create worker config after the config stable.

@poyoho poyoho changed the title fix: worker config without origin user config fix: don't modify config Jul 21, 2022
@bholmesdev
Copy link
Contributor

Can confirm this resolves our issue in CI! 🥳

bluwy
bluwy approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add docs about main/worker plugins interaction in a separate PR if you prefer 🙂

@patak-dev patak-dev merged commit bbc8318 into main Jul 21, 2022
@patak-dev patak-dev deleted the config/worker-config-override branch July 21, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red left review comments

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[astro ci] Cannot read property 'isSelfAccepting' of undefined
5 participants
@poyoho @sapphi-red @bholmesdev @patak-dev @bluwy