docs(wasm): add sections about Node.js and module access #13978
Conversation
This also renames the example import from `imports` to `someModule`. It's easy to think `imports` is a magic key. Closes vitejs#13965.
|
|
docs/guide/features.md
Outdated
|
|
||
| ```js | ||
| init({ | ||
| imports: { | ||
| someModule: { |
There was a problem hiding this comment.
Maybe it is better to align with MDN here, they are using imports so I would suggest we stick with the current naming: https://developer.mozilla.org/en-US/docs/WebAssembly/JavaScript_interface/instantiate#first_overload_example
There was a problem hiding this comment.
I'll note that the spec uses "js" as the sample module name: https://webassembly.github.io/spec/js-api/#sample
(MDN also tripped me up in trying to understand the parameter, so I'd love to not just do what they do. :)
That case having been made, if you want "imports", sure.
There was a problem hiding this comment.
I let @sapphi-red weight on this one. Thanks for the changes!
There was a problem hiding this comment.
SG. Thanks for the review and providing Vite!
There was a problem hiding this comment.
I'll select imports as I assume more people would read MDN than the spec.
docs/guide/features.md
Outdated
|
|
||
| ```js | ||
| init({ | ||
| imports: { | ||
| someModule: { |
There was a problem hiding this comment.
I'll select imports as I assume more people would read MDN than the spec.
Co-authored-by: 翠 / green <[email protected]>
Description
This also renames the example import from
importstosomeModule. It's easy to thinkimportsis a magic key.Closes #13965.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).