fix(browser): init browsers eagerly when tests are running #6876

sheremet-va · 2024-11-07T12:19:10Z

Description

This PR changes when the vite server is started. Previously, every project initialised a server before the onInit hook was called. Now it's initialised right before the tests are queued to run.

For example, this avoids creating the server when the --project filter is used. This also won't start a server in --standalone mode until the tests are actually running

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2024-11-07T12:21:54Z

✅ Deploy Preview for vitest-dev ready!

Name	Link
🔨 Latest commit	`117c3a5`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/672cb04160a3dd000821f243
😎 Deploy Preview	https://deploy-preview-6876--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-11-13T12:18:41Z

✅ Deploy Preview for vitest-dev ready!

Name	Link
🔨 Latest commit	`3394667`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/6734b8ea50fde90008d0538d
😎 Deploy Preview	https://deploy-preview-6876--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va

##### [v2.1.5](https://github.com/vitest-dev/vitest/releases/tag/v2.1.5) ##### 🚀 Features - **experimental**: Expose vite on the test project as a separate field - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(bcc59)</samp>](vitest-dev/vitest@bcc59088) ##### 🐞 Bug Fixes - `dangerouslyIgnoreUnhandledErrors` without base reporter - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6808 [<samp>(0bf0a)</samp>](vitest-dev/vitest@0bf0ab00) - Capture `unhandledRejection` even when base reporter is not used - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6812 [<samp>(8878b)</samp>](vitest-dev/vitest@8878b04d) - Don't change the working directory when loading workspace projects - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6811 [<samp>(f0aea)</samp>](vitest-dev/vitest@f0aeaca8) - Remove `sequence.concurrent` from the `RuntimeConfig` type - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6880 [<samp>(6af73)</samp>](vitest-dev/vitest@6af73d93) - Stop the runner before restarting, restart on workspace config change - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6859 [<samp>(b01df)</samp>](vitest-dev/vitest@b01df47d) - Don't rerun on Esc or Ctrl-C during watch filter - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6895 [<samp>(98f76)</samp>](vitest-dev/vitest@98f76ea7) - Print ssrTransform error - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6885 [<samp>(4c96c)</samp>](vitest-dev/vitest@4c96cce7) - Throw an error and a warning if `.poll`, `.element`, `.rejects`/`.resolves`, and `locator.*` weren't awaited - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6877 [<samp>(93b67)</samp>](vitest-dev/vitest@93b67c24) - **browser**: - Don't process the default css styles - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6861 [<samp>(0d67f)</samp>](vitest-dev/vitest@0d67f04b) - Support non US key input - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6873 [<samp>(5969d)</samp>](vitest-dev/vitest@5969d8da) - Stop the browser rpc when the pool is closed - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6858 [<samp>(9a0c9)</samp>](vitest-dev/vitest@9a0c93d7) - Init browsers eagerly when tests are running - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6876 [<samp>(417bd)</samp>](vitest-dev/vitest@417bdb42) - **coverage**: - Report uncovered files when re-run by `enter` or `'a'` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6848 [<samp>(487c8)</samp>](vitest-dev/vitest@487c80ae) - **ui**: - Remove crossorigin attributes for same origin assets - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6883 [<samp>(6e793)</samp>](vitest-dev/vitest@6e793c64) - **vite-node**: - Improve esm check to decide external - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6816 [<samp>(7e1fa)</samp>](vitest-dev/vitest@7e1faf3d) - Top-level throw in module is not reported properly - by [@vanaigr](https://github.com/vanaigr) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6840 [<samp>(cf0cb)</samp>](vitest-dev/vitest@cf0cbf6a) - **vitest**: - Use fetch() implementation from happy-dom - by [@capricorn86](https://github.com/capricorn86) in vitest-dev/vitest#6879 [<samp>(3c56f)</samp>](vitest-dev/vitest@3c56feb4) ##### 🏎 Performance - Limit workspace project concurrency to available cores - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6869 [<samp>(f4c04)</samp>](vitest-dev/vitest@f4c04ab6) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.4...v2.1.5)

@sheremet-va

##### [v2.1.5](https://github.com/vitest-dev/vitest/releases/tag/v2.1.5) ##### 🚀 Features - **experimental**: Expose vite on the test project as a separate field - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(bcc59)</samp>](vitest-dev/vitest@bcc59088) ##### 🐞 Bug Fixes - `dangerouslyIgnoreUnhandledErrors` without base reporter - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6808 [<samp>(0bf0a)</samp>](vitest-dev/vitest@0bf0ab00) - Capture `unhandledRejection` even when base reporter is not used - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6812 [<samp>(8878b)</samp>](vitest-dev/vitest@8878b04d) - Don't change the working directory when loading workspace projects - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6811 [<samp>(f0aea)</samp>](vitest-dev/vitest@f0aeaca8) - Remove `sequence.concurrent` from the `RuntimeConfig` type - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6880 [<samp>(6af73)</samp>](vitest-dev/vitest@6af73d93) - Stop the runner before restarting, restart on workspace config change - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6859 [<samp>(b01df)</samp>](vitest-dev/vitest@b01df47d) - Don't rerun on Esc or Ctrl-C during watch filter - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6895 [<samp>(98f76)</samp>](vitest-dev/vitest@98f76ea7) - Print ssrTransform error - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6885 [<samp>(4c96c)</samp>](vitest-dev/vitest@4c96cce7) - Throw an error and a warning if `.poll`, `.element`, `.rejects`/`.resolves`, and `locator.*` weren't awaited - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6877 [<samp>(93b67)</samp>](vitest-dev/vitest@93b67c24) - **browser**: - Don't process the default css styles - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6861 [<samp>(0d67f)</samp>](vitest-dev/vitest@0d67f04b) - Support non US key input - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6873 [<samp>(5969d)</samp>](vitest-dev/vitest@5969d8da) - Stop the browser rpc when the pool is closed - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6858 [<samp>(9a0c9)</samp>](vitest-dev/vitest@9a0c93d7) - Init browsers eagerly when tests are running - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6876 [<samp>(417bd)</samp>](vitest-dev/vitest@417bdb42) - **coverage**: - Report uncovered files when re-run by `enter` or `'a'` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6848 [<samp>(487c8)</samp>](vitest-dev/vitest@487c80ae) - **ui**: - Remove crossorigin attributes for same origin assets - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6883 [<samp>(6e793)</samp>](vitest-dev/vitest@6e793c64) - **vite-node**: - Improve esm check to decide external - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6816 [<samp>(7e1fa)</samp>](vitest-dev/vitest@7e1faf3d) - Top-level throw in module is not reported properly - by [@vanaigr](https://github.com/vanaigr) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6840 [<samp>(cf0cb)</samp>](vitest-dev/vitest@cf0cbf6a) - **vitest**: - Use fetch() implementation from happy-dom - by [@capricorn86](https://github.com/capricorn86) in vitest-dev/vitest#6879 [<samp>(3c56f)</samp>](vitest-dev/vitest@3c56feb4) ##### 🏎 Performance - Limit workspace project concurrency to available cores - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6869 [<samp>(f4c04)</samp>](vitest-dev/vitest@f4c04ab6) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.4...v2.1.5)

sheremet-va marked this pull request as draft November 7, 2024 12:19

sheremet-va added 3 commits November 13, 2024 12:57

fix(browser): init browsers eagerly when tests are running

bdd828f

chore: hm

104002d

test: fix tests

c1e23c5

sheremet-va force-pushed the fix/init-browser-eagerly branch from 78f5969 to c1e23c5 Compare November 13, 2024 12:16

test: fix browser test

dee9478

sheremet-va marked this pull request as ready for review November 13, 2024 14:25

sheremet-va added 2 commits November 13, 2024 15:32

test: fix unordered list

332aba0

chore: cleanup

3394667

sheremet-va merged commit 417bdb4 into vitest-dev:main Nov 13, 2024
17 checks passed

sheremet-va deleted the fix/init-browser-eagerly branch November 13, 2024 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(browser): init browsers eagerly when tests are running #6876

fix(browser): init browsers eagerly when tests are running #6876

sheremet-va commented Nov 7, 2024 •

edited

Loading

netlify bot commented Nov 7, 2024

netlify bot commented Nov 13, 2024 •

edited

Loading

fix(browser): init browsers eagerly when tests are running #6876

fix(browser): init browsers eagerly when tests are running #6876

Conversation

sheremet-va commented Nov 7, 2024 • edited Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

netlify bot commented Nov 7, 2024

✅ Deploy Preview for vitest-dev ready!

netlify bot commented Nov 13, 2024 • edited Loading

✅ Deploy Preview for vitest-dev ready!

sheremet-va commented Nov 7, 2024 •

edited

Loading

netlify bot commented Nov 13, 2024 •

edited

Loading