Style MuiCard system
#2890
Open
Style MuiCard system
#2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
force-pushed
the
style-mui-card-system
branch
from
a7b1015 to
119bb26
Compare
added 3 commits
December 5, 2024 17:20
juliawegmayr
force-pushed
the
style-mui-card-system
branch
from
119bb26 to
fadfcea
Compare
jamesricky
reviewed
Dec 5, 2024
Comment on lines
+11
to
+14
| "& .MuiButtonBase-root": { | ||
| paddingTop: 0, | ||
| paddingBottom: 0, | ||
| }, |
There was a problem hiding this comment.
Simply removing the padding makes the button look weird during click/focus...
In the design it seems this is a custom button anyway, as the hover is different than in other buttons.
I will check with UX to see if this is on purpose or if we can use an existing button variant here.
| Implementation | Design |
|---|---|
Screen.Recording.2024-12-05.at.17.38.20.mov |
Screen.Recording.2024-12-05.at.17.33.45.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Style
CardandCardHeaderaccording to Comet DXP designExample
Screenshots/screencasts
Changeset
Related tasks and documents
https://vivid-planet.atlassian.net/browse/COM-1253
Design: https://www.figma.com/design/Swzee5YSEkPVlCXHcyL7mp/COMET-DXP-Library?node-id=4180-9193&node-type=canvas&t=D9O6qzMrvU1YIVyh-0