Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail pipeline if test results file is missing #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bothzoli
Copy link
Contributor

@bothzoli bothzoli commented Dec 6, 2024

The changes in this PR will make sure that the build pipeline fails if no tests were run for any reason.
This will prevent issues like #580 in the future.

The PR also fixes the failing tests project.
This also revealed another issue regarding obsolete BinaryFormatter.
New issue #587 was opened to address this.

Resolves: #580

@bothzoli bothzoli force-pushed the fix/failing-test-step-in-pipeline branch 4 times, most recently from 3f08c8a to 9d00056 Compare December 6, 2024 11:51
This will make sure that the pipeline will not report success if for
some reason the test results file is not generated.

Issue vkhorikov#580
@bothzoli bothzoli force-pushed the fix/failing-test-step-in-pipeline branch from 9d00056 to 983d18a Compare December 6, 2024 12:33
@bothzoli bothzoli force-pushed the fix/failing-test-step-in-pipeline branch from 95bf853 to a215314 Compare December 6, 2024 12:57
@bothzoli bothzoli marked this pull request as ready for review December 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failures are ignored in CI pipeline
1 participant