Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help wanted]: website ui improvement #10089

Closed
1 task done
youkaichao opened this issue Nov 6, 2024 · 2 comments · Fixed by #10090
Closed
1 task done

[help wanted]: website ui improvement #10089

youkaichao opened this issue Nov 6, 2024 · 2 comments · Fixed by #10090
Labels

Comments

@youkaichao
Copy link
Member

Anything you want to discuss about vllm.

image

currently, "ask AI" and doc version selection are overlapped.

we should move doc version selection to the left.

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@rafvasq
Copy link
Contributor

rafvasq commented Nov 8, 2024

From what I've read, moving the version selector isn't supported out of the box with the current book theme which extends from the PyData theme (pydata/pydata-sphinx-theme#705) and otherwise I think it would be a busy CSS workaround unless vLLM adopts the ReadTheDocs theme to easily attach it to the sidebar

I think the simplest solution would be to move the AskAI button instead and then, using the current theme, I could also work on introducing the theme's supported Version Selector. Let me know what you think @youkaichao!

@youkaichao
Copy link
Member Author

didn't expect it is complicated as this. thanks for your hard work, and let's keep the AskAI button in the left then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants