Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add DoRA support #10849

Open
1 task done
cmhungsteve opened this issue Dec 3, 2024 · 3 comments
Open
1 task done

[Feature]: add DoRA support #10849

cmhungsteve opened this issue Dec 3, 2024 · 3 comments

Comments

@cmhungsteve
Copy link

🚀 The feature, motivation and pitch

The recent ICML'24 Oral paper, DoRA, has shown consistent improvement over LoRA on various tasks (LLM, MLLM, etc.) and backbones (LLaMA, LLaVA, etc.)
[Code] https://github.com/NVlabs/DoRA

DoRA has also been integrated into various open-source library/framework:

teaser_v2_bg

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@jeejeelee
Copy link
Collaborator

Thank you very much for bringing this feature. We will consider supporting it.

@TC10127
Copy link

TC10127 commented Dec 3, 2024

I also need vllm to support dora !!!

@PacinoAn
Copy link

PacinoAn commented Dec 3, 2024

We need this feature too,this will help a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants