Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorded profile end time is too late, making it hard to timestamp each sample #233

Open
oremanj opened this issue Apr 30, 2021 · 1 comment

Comments

@oremanj
Copy link

oremanj commented Apr 30, 2021

vmprof.disable() stops sampling, then does an expensive scan of code objects and debug info to symbolize addresses, then fsync()'s the profile, and only then records the end timestamp. In my experience this results in an end timestamp that's between 80 and 500 milliseconds after the sampling actually stopped, which interferes with efforts to match up vmprof-recorded stacks against other sources of profiling information.

Could the end time recorded in the profile be made to more closely match the time at which sampling last stopped?

@fijal
Copy link
Member

fijal commented May 3, 2021

Hi

That does make sense. Never thought about it. Feel free to issue a pull request to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants