-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uploader-type default should be kopia #549
Comments
@qiuming-best could you help this issue? thanks |
@jenting OK |
isn't this a breaking change for everyone that didn't explicitly set restic? |
yes, we missed to bump the minor version :( |
I've said this before, although I can't find it now, but people rely on versioning! And not only did you miss to bump the version, you wanted to bump the minor version for a breaking change?! Breaking changes are major version bumps, see https://semver.org For this reason, you are the only chart of dozens of charts that we're using that has a pinned version, as we can't rely on this. |
@cwrau who said they follow semver? not every project does. You shouldn't just use version ranges assuming semver. Or if you do, you do it accepting a certain risk. I noticed the change while reading changelog (as you should do for important software) and asked if I'm understanding it correctly. |
I guess so, but then they should state that somewhere, as semver has been the defacto standard for a couple of years now. And if they don't follow semver, I'd kindly ask them to do it, as semver is extremely helpful in conveying information without the need to dig deep.
In light of this, yes, now we're going to look deeper at versioning of other projects.
Yeah, that's why we had to switch to a pinned version for velero 🙄 |
Honestly I know very few projects that stick to semver close enough for me to blindly follow it. I always decide on a project by project basis. It's always a discussion of "is this change breaking enough to warrant a major version change", many projects accept minor breakages, but the impact might still be huge for you. But maybe I've been burned to many times and just got overly cautious. Anyway, I guess feel free to open a request for stricter semver. |
What steps did you take and what happened:
The docs say
uploader-type
will default to kopia if empty in https://velero.io/docs/main/file-system-backup/ "Path selection". The helm chart defaults to restic - chartsThe text was updated successfully, but these errors were encountered: