Send md5 of customer key #217
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Strache <[email protected]> Signed-off-by: Robert Strache <[email protected]>
Signed-off-by: Robert Strache <[email protected]>
Signed-off-by: Robert Strache <[email protected]> Signed-off-by: Robert Strache <[email protected]>
robertstrache
force-pushed
the
send-md5-of-customer-key
branch
from
b62bcb3 to
72186f7
Compare
reasonerjt
reviewed
Oct 22, 2024
| @@ -267,6 +282,7 @@ func (o *ObjectStore) PutObject(bucket, key string, body io.Reader) error { | |||
| case o.sseCustomerKey != "": | |||
| input.SSECustomerAlgorithm = aws.String("AES256") | |||
| input.SSECustomerKey = &o.sseCustomerKey | |||
| input.SSECustomerKeyMD5 = &o.sseCustomerKeyMd5 | |||
There was a problem hiding this comment.
Will the func "GetObject" and "ObjectExists" also need this change?
reasonerjt
dismissed
their stale review
I have some question, so undoing the approval.
|
This PR has some code duplication (readCustomerKey is called twice now), also comment was correct, that this is missing for head and get operations. I created a new PR for this: #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should send the MD5 checksum of a customer provided encryption key.
It is taken from a comment of another user in vmware-tanzu/velero#7693
I have just turned it into a PR since it seems to solve our issue described in
vmware-tanzu/velero#7693